feat: add secp256k1 ecrecover precompile #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
reviewed
Sep 30, 2025
hero78119
reviewed
Sep 30, 2025
hero78119
requested changes
Oct 1, 2025
lightsing
force-pushed
the
feat/secp256k1-guest
branch
from
59e641a to
20b947b
Compare
|
@hero78119 I reconsidering the approach to add secp256k1 support, I prefer to fork & modify k256 crate and use it here now. see also the sp1 codes: |
hero78119
reviewed
Oct 13, 2025
There was a problem hiding this comment.
Overall LGTM!
btw @lightsing could you also left some hints for future works, e.g. how to patch syscall for k256 to accelerate bigint operation? it would help when bigint precompile ready 🙏
|
Note that in this version, we don't have bigint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch crate: https://github.com/scroll-tech/elliptic-curves/tree/ceno/k256-13.4
test_secp256k1_ecrecover, runs 5 ecrecover: